Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake test-inspector-strip-types #55058

Merged
merged 1 commit into from
Sep 24, 2024
Merged

test: deflake test-inspector-strip-types #55058

merged 1 commit into from
Sep 24, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Sep 22, 2024

Use the NodeRuntime.waitingForDebugger event.

Refs: #51560

@lpinca
test: deflake test-inspector-strip-types
d1f4a31 
Use the `NodeRuntime.waitingForDebugger` event.

Refs: nodejs#51560
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2024
@lpinca
Copy link
Member Author

lpinca commented Sep 22, 2024 •
edited
Loading

Fixes https://ci.nodejs.org/job/node-test-commit-linuxone/46006/nodes=rhel9-s390x/testReport/junit/(root)/parallel/test_inspector_strip_types/

---
duration_ms: 15234.513
exitcode: 1
severity: fail
stack: |-
  [test] Connecting to a child Node process
  [test] Testing /json/list
  [err] Debugger listening on ws://127.0.0.1:42023/4731393b-b955-4019-8f07-0182e30cf571
  [err] For help, see: https://nodejs.org/en/docs/inspector
  [err]
  [err] Debugger attached.
  [err]
  Timed out waiting for matching notification ((notification) => {
      if (notification.method !== 'Debugger.scriptParsed') return false;

      return notification.params.url === scriptPath;
    })
  1
...

Before:

$ python3 tools/test.py --repeat=1000 test/parallel/test-inspector-strip-types.js 
=== release test-inspector-strip-types ===                   
Path: parallel/test-inspector-strip-types
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:49443/ea1dd0d0-5c93-4ca6-9fd1-a73e017800bb
[err] For help, see: https://nodejs.org/en/docs/inspector
[err] 
[err] Debugger attached.
[err]
Timed out waiting for matching notification ((notification) => {
    if (notification.method !== 'Debugger.scriptParsed') return false;

    return notification.params.url === scriptPath;
  })
1
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js


...


[00:53|% 100|+ 993|-   7]: Done                              

Failed tests:
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js
out/Release/node /Users/luigi/code/node/test/parallel/test-inspector-strip-types.js

After:

$ python3 tools/test.py --repeat=1000 test/parallel/test-inspector-strip-types.js 
[00:45|% 100|+ 1000|-   0]: Done                             

All tests passed.

@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (cfe58cf) to head (d1f4a31).
Report is 422 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55058   +/-   ##
=======================================
  Coverage   88.23%   88.23%           
=======================================
  Files         652      652           
  Lines      183912   183912           
  Branches    35865    35868    +3     
=======================================
+ Hits       162272   162275    +3     
  Misses      14915    14915           
+ Partials     6725     6722    -3

see 38 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62664/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 22, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 22, 2024 •
edited by jakecastelli
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/62668/ 💚

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 23, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024
@nodejs-github-bot nodejs-github-bot merged commit 3c5ceff into nodejs:main Sep 24, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3c5ceff

@lpinca lpinca deleted the deflake/test-inspector-strip-types branch September 24, 2024 06:00
targos pushed a commit that referenced this pull request Oct 4, 2024
@lpinca @targos
test: deflake test-inspector-strip-types
93c23e7 
Use the `NodeRuntime.waitingForDebugger` event.

Refs: #51560
PR-URL: #55058
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@lpinca @louwers
test: deflake test-inspector-strip-types
fde32fc 
Use the `NodeRuntime.waitingForDebugger` event.

Refs: nodejs#51560
PR-URL: nodejs#55058
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@lpinca @tpoisseau
test: deflake test-inspector-strip-types
98666de 
Use the `NodeRuntime.waitingForDebugger` event.

Refs: nodejs#51560
PR-URL: nodejs#55058
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@aduh95 aduh95 aduh95 approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lpinca @nodejs-github-bot @legendecas @aduh95 @atlowChemi @marco-ippolito